After a frantic 12 weeks, we have arrived at Release 0.4 - AKA the final release for the DPS909 Open-source course. Much like the previous release I covered, this release is comprised of two parts: an internal pull request to CDOT Telescope, and a more challenging external pull request to an open-source project.
To improve your reading experience, I've also split my blog up into two parts. This post will be covering my internal contribution to CDOT Telescope.
For a full description on what Telescope is, please refer to my previous post where I introduced it in detail, or the official overview.
The Issue - Search icon floating with window resize
Another student had added a dynamically floating search bar to the front end, however it was not functioning correctly as it would sporadically float around as you scroll or resize the page.
The initial hypothesis was that it was positioned relative to the view port cs it's container. However adjusting the property did not solve the issue and introduced even more problems as the buttons stopped responding. In fact, any positional or relational changes to the it's properties would break it. My assumption was that this code was likely taken from another source without being fully understood.
The Pull Request - Replacing the Search Bar
The best course of action here was to implement a search bar with an implementation that was understood and uniform with the Boostrap MD theme that was already chosen for the website. I went through the documentation for the theme and found a search bar. I went ahead and implemented it and customized it's sizing, spacing, and co louring to match. The result was a very clean, functional search bar the suit the theme of the website and it's neighboring elements very well.
After passing some reviews, it was merged into the master branch.
Whats next?
That sums it up for mt internal contribution. For a summary of my external contribution, check out my next post.
To improve your reading experience, I've also split my blog up into two parts. This post will be covering my internal contribution to CDOT Telescope.
For a full description on what Telescope is, please refer to my previous post where I introduced it in detail, or the official overview.
The Issue - Search icon floating with window resize
 |
| Demonstration of the floating search issue |
The initial hypothesis was that it was positioned relative to the view port cs it's container. However adjusting the property did not solve the issue and introduced even more problems as the buttons stopped responding. In fact, any positional or relational changes to the it's properties would break it. My assumption was that this code was likely taken from another source without being fully understood.
The Pull Request - Replacing the Search Bar
 |
| Screenshot of new functional search bar |
After passing some reviews, it was merged into the master branch.
Whats next?
That sums it up for mt internal contribution. For a summary of my external contribution, check out my next post.
Comments
Post a Comment