Skip to main content

Release 0.4 - My Internal Pull Request to Telescope

After a frantic 12 weeks, we have arrived at Release 0.4 - AKA the final release for the DPS909 Open-source course. Much like the previous release I covered, this release is comprised of two parts: an internal pull request to CDOT Telescope, and a more challenging external pull request to an open-source project.

To improve your reading experience, I've also split my blog up into two parts. This post will be covering my internal contribution to CDOT Telescope.

For a full description on what Telescope is, please refer to my previous post where I introduced it in detail, or the official overview.


The Issue - Search icon floating with window resize 

search-icon-bug
Demonstration of the floating search issue
Another student had added a dynamically floating search bar to the front end, however it was not functioning correctly as it would sporadically float around as you scroll or resize the page.

 The initial hypothesis was that it was positioned relative to the view port cs it's container. However adjusting the property did not solve the issue and introduced even more problems as the buttons stopped responding. In fact, any positional or relational changes to the it's properties would break it. My assumption was that this code was likely taken from another source without being fully understood.

The Pull Request - Replacing the Search Bar

image
Screenshot of new functional search bar
The best course of action here was to implement a search bar with an implementation that was understood and uniform with the Boostrap MD theme that was already chosen for the website. I went through the documentation for the theme and found a search bar. I went ahead and implemented it and customized it's sizing, spacing, and co louring to match. The result was a very clean, functional search bar the suit the theme of the website and it's neighboring elements very well.

After passing some reviews, it was merged into the master branch.

Whats next?
That sums it up for mt internal contribution. For a summary of my external contribution, check out my next post.


Comments

Post a Comment

Popular posts from this blog

Micro-Note : My First Steps into Open Source

I just finished building Micro-Note, a simple web based note taking application. While it is not the most innovative app, it marks my first steps into the world of open source. Not only was I able to learn and exercise essential Git skills including the creation and operation of a repo, but also brush up on my web development basics. This involved both features found on the GitHub web app, and the Git command line interface. I found this highly useful as I am aware Git will be a part of my career moving forward, whether it be for open source or other ventures as a developer. The app is simple and fairly self explanatory.  It allows the user to input notes into the web page and save them to continue or edit them later if needed. It is built with the standard web stack, HTML5, CSS, and JavaScript. It uses the  FilerJS Browser Filesystem library to save the user input to a local file so the user can save and resume their note-taking at later time.  This was helpful as...
Post a Comment
Read more

My First Contributions and Collaborations in Open-Source

This week I continued my journey into the world of open source by contributing to the work of others, as well as accepting contributions from others for my Micro-Note web app detailed in the previous blog post . I was able to contribute one bug fix, and one additional feature to similar applications built by other students. This was done by utilizing Git features such as posting issues, forking repositories, creating new branches, and creating/receiving pull requests. Details of my contributions are explained below. In addition to these, I also received my first pull request to review nad merge another students contributions to my own application. Fixing Another Students Bug One of my colleagues ( dbeigi ) built a note taking application called " whiteboard " that allows users to save their notes using hotkey inputs, otherwise the application is meant to automatically save the users work every 4 seconds. While I was reviewing the code, I noticed the paramter in the setInt...
Post a Comment
Read more

Lab 8 - Contribution Goals for CDOT Telescope & LifeStyle E-Commerce

After successfully completing Hacktoberfest, we move onto bigger and better challenges in open source. By November 15th I have the following goals to complete: 1. Contribute to a bigger issue on an open-source project (no more "good-first-issue" tags). 2. Contribute to CDOT Telescope, an internal project built by my fellow classmates. In this post I will break down my issue and goal for each goal. External Project- LifeStyle E-Commerce  This is a project I found in hacktoberfest and fixed a styling alignment bug for. You can find the full details of my contribution in my previous post.   If you are already familiar wit the project, you can skip the overview section. Overview Lifestyle E-ommerce is a front-end project for building an online store. It supplies various well designed pages for front-end developers to customize and utilize as a starting point for their e-commerce projects, whether it be for themselves or their clients. I gravitated towards this ...
Post a Comment
Read more