Skip to main content

Release 0.4 - My Internal Pull Request to Telescope

After a frantic 12 weeks, we have arrived at Release 0.4 - AKA the final release for the DPS909 Open-source course. Much like the previous release I covered, this release is comprised of two parts: an internal pull request to CDOT Telescope, and a more challenging external pull request to an open-source project.

To improve your reading experience, I've also split my blog up into two parts. This post will be covering my internal contribution to CDOT Telescope.

For a full description on what Telescope is, please refer to my previous post where I introduced it in detail, or the official overview.


The Issue - Search icon floating with window resize 

search-icon-bug
Demonstration of the floating search issue
Another student had added a dynamically floating search bar to the front end, however it was not functioning correctly as it would sporadically float around as you scroll or resize the page.

 The initial hypothesis was that it was positioned relative to the view port cs it's container. However adjusting the property did not solve the issue and introduced even more problems as the buttons stopped responding. In fact, any positional or relational changes to the it's properties would break it. My assumption was that this code was likely taken from another source without being fully understood.

The Pull Request - Replacing the Search Bar

image
Screenshot of new functional search bar
The best course of action here was to implement a search bar with an implementation that was understood and uniform with the Boostrap MD theme that was already chosen for the website. I went through the documentation for the theme and found a search bar. I went ahead and implemented it and customized it's sizing, spacing, and co louring to match. The result was a very clean, functional search bar the suit the theme of the website and it's neighboring elements very well.

After passing some reviews, it was merged into the master branch.

Whats next?
That sums it up for mt internal contribution. For a summary of my external contribution, check out my next post.


Comments

Popular posts from this blog

Release 0.4 - My External Pull Request to Uber

Continuing from my previous post , I will now be covering my external contribution for Release 0.4. This external pull request is my biggest and most challenging one to date. The challenge came from size of the project, as searching and navigating through it's code base felt like somewhat of a rats maze to find where the issue lies. I also had minimal experience in React (one small school project), so the unfamiliarity with the language and architecture presented some challenges as well. The Project -  Uber - Base Web In short, Base Web is Uber's web based design system comprised of "modern, responsive, living components" implemented in ReactJS. This project contains a vast variety of functional web components that can be used by web developers the front-end of their web projects. As someone who has done freelance web development in the past, I've always appreciated the availability of open source libraries, especially the more complex one's such as this

Hacktoberfest - Pull Request #2 : Rhymus

In my previou s post , I announced and explained my first pull request for this year's Hacktoberfest event, where I contributed to the documentation of CMS program called RawCMS. I also mentioned that documentation was simply a starting point for me as I aimed to contribute to the code/content of an actual application for my next pull request. I can proudly say that I succeeded in reaching this goal for my second pull request, as I was able to contribute to a project called Rhymus . The Project: Rhymus Rhymus is an open-source web based game written in HTML, CSS and Javascript. It presents the user with word based puzzles to help users improve their vocabulary and familiarity with some common expressions, Phrases and/or common expressions are shown with on of the words being replaced with a rhyme for the original. The user must input what the correct word is, and has the option to take a hint for less point. The game has a scoring system to measure the users success. All in a

Release 0.3 - Pull Requests Telescope & LifeStyle Ecommerce

In my previous pos t, I revealed the issues I will be attempting to resolve in order to contribute for an internal project and an external project. I also detailed the projects themselves, so if you haven't already read my previous post, I would advise starting there to give my current post some context. I can successfully say I reached the goals I set for both the external and internal project in my previous post. Keep reading to find out how I did this, and the challenges I overcame. Internal Pull Request Adding Pagination to CDOT Telescope The responsive page navigation is circled at the bottom This issue was assigned to me by a colleague and was much trickier than I initially anticipated. The issue simply required to implement paginating functionality to the front end, so that the blog posts are displayed in pages instead of all  being displayed in one very long scrollable feed. The first challenge came with the starting point. The home page was designed wi